perf: Add accountIdByAddress to AccountsController state#7893
Open
perf: Add accountIdByAddress to AccountsController state#7893
accountIdByAddress to AccountsController state#7893Conversation
hmalik88
changed the title
accountIdByAddress to AccountsController stateaccountIdByAddress to AccountsController state
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ccharly
reviewed
Feb 10, 2026
ccharly
reviewed
Feb 10, 2026
ccharly
reviewed
Feb 10, 2026
gantunesr
reviewed
Feb 16, 2026
gantunesr
reviewed
Feb 16, 2026
hmalik88
changed the title
accountIdByAddress to AccountsController stateaccountIdByAddress to AccountsController state
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
gantunesr
reviewed
Feb 27, 2026
Member
gantunesr
left a comment
gantunesr
left a comment
There was a problem hiding this comment.
Looks good, lets just solve the comment left by cursor
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently when doing an account lookup by address we're doing an O(n) operation in the clients, this has been improved to O(1) by adding an address -> account id mapping in state. The
getAccountByAddressfunction now also takes advantage of this new piece of state to improve its lookup time.Note: This will require a migration in the clients.
References
N/A
Checklist
Note
Medium Risk
State shape changes by adding
accountIdByAddress(non-persisted) and makinggetAccountByAddressdepend on it, which requires client-side migration and could break lookups if callers use differently-cased addresses than the stored key.Overview
Adds an address→account ID index to
AccountsControllerstate (accountIdByAddress) to make address-based account lookups O(1).getAccountByAddressnow resolves via this map, and the controller keeps the map in sync when constructing initial state, updating accounts from keyrings, loading backups, and processing account add/remove patches. Tests and fixtures across dependent packages are updated to include the new state field, and a newconstructAccountIdByAddresshelper (with tests) is introduced; the changelog documents the change.Written by Cursor Bugbot for commit 22ff1f0. This will update automatically on new commits. Configure here.